Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will napi_set_function_name work with spidermonkey #26

Closed
mhdawson opened this issue Dec 5, 2016 · 2 comments
Closed

Will napi_set_function_name work with spidermonkey #26

mhdawson opened this issue Dec 5, 2016 · 2 comments

Comments

@mhdawson
Copy link
Member

mhdawson commented Dec 5, 2016

  • Version: ALL
  • Platform: ALL
  • Subsystem: API

Comment from Ben in nodejs/node-eps#20 (comment), we'll need to see if:

NODE_EXTERN void napi_set_function_name(napi_env e, napi_value func,
+                                        napi_propertyname napi_value);

will work with other engines like spidermonkey were the name it declared up front.

@aruneshchandra
Copy link
Contributor

@mykmelez do you have any idea about this ?

@jasongin
Copy link
Member

jasongin commented Feb 6, 2017

ChakraCore also can only set the name when the function is created. For issue #78 we decided to remove napi_set_function_name and add an optional name parameter to napi_create_function instead.

@jasongin jasongin closed this as completed Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants