Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring 'node-inspect' (CLI Debugger) under the Foundation #190

Closed
joshgav opened this issue Jan 3, 2017 · 11 comments
Closed

Bring 'node-inspect' (CLI Debugger) under the Foundation #190

joshgav opened this issue Jan 3, 2017 · 11 comments

Comments

@joshgav
Copy link
Contributor

joshgav commented Jan 3, 2017

As summarized in nodejs/diagnostics#67, work is underway to replace Node's current built-in CLI debugger (node debug) with a new one compatible with the new Inspector Protocol. @jkrems has an implementation at https://github.com/buggerjs/node-inspect and work has begun in nodejs/node#10187 to include this as a third-party dependency under "deps" in nodejs/node.

We'll likely also further integrate it into the standard Node binary so that node debug or node inspect work out-of-the-box as in the past, see nodejs/node#10187 for discussion.

Since the CLI debugger is a significant component of Node core, and because we'd like to facilitate broader and deeper work on this basic diagnostic tool, the @nodejs/diagnostics WG recommends that the TSC:

  1. Bring node-inspect under the governance of the Node Foundation.
  2. Bring the node-inspect repo into the nodejs GitHub org.

I believe all necessary prerequisites as described in TSC/Project-Lifecycle.md have been completed.

Thanks!

@mhdawson
Copy link
Member

mhdawson commented Jan 5, 2017

I'm +1 on moving forward on this.

@joshgav
Copy link
Contributor Author

joshgav commented Jan 13, 2017

The TSC concluded in yesterday's meeting to bring in node-inspect as proposed, pending agreement from the CTC. I think the next step would be to ask @nodejs/ctc to chime in here or in nodejs/CTC#40 to finalize.

@jasnell or @mhdawson can you please label with ctc-agenda or ctc-review to get people's attention? Thanks!

@MylesBorins
Copy link
Contributor

MylesBorins commented Jan 13, 2017

Should we open a new issue for voting or just vote in the already open issue?

edit: i'm +1

@joshgav
Copy link
Contributor Author

joshgav commented Jan 13, 2017

@MylesBorins seems +1's here or in the CTC issue should be sufficient, there are a lot of issues open already :)

If we have enough votes in favor in the issues I'll collect them before the next TSC meeting and we can move forward, if not we can bring it up again in the Jan-25 CTC meeting to finalize.

Thanks!

@Trott
Copy link
Member

Trott commented Jan 14, 2017

+1 from me!

@Trott
Copy link
Member

Trott commented Jan 18, 2017

At today's CTC meeting, this received additional "yes" votes from @Fishrock123 @addaleax @mscdex @rvagg @bnoordhuis @thefourtheye @jasnell @ChALkeR and @trevnorris. As this already has 3 yes votes from CTC members above (me, @mhdawson, and @MylesBorins), that's 12 yes votes, which is a majority of the CTC. This passes.

I'll remove the ctc-agenda label. Hopefully someone knowledgable can indicate what the next step is now that this has passed. (CC @williamkapke I guess.)

@Trott Trott removed the ctc-agenda label Jan 18, 2017
@williamkapke
Copy link
Contributor

It looks like all of the documents are in place -- awesome work @nodejs/diagnostics !

It just needs to be transferred and @rvagg needs to add it to the TSC's scope doc PR: #144

@joshgav
Copy link
Contributor Author

joshgav commented Jan 23, 2017

Thanks everyone, especially @jkrems for this donation! @nodejs/evangelism can you perhaps give him a shout-out in the next newsletter?

Repo is now available at https://github.com/nodejs/node-inspect 🎉

@joshgav joshgav closed this as completed Jan 23, 2017
@jkrems
Copy link

jkrems commented Jan 23, 2017

If there's a shout-out in the newsletter, it would be good to also mention @groupon since they sponsored some of my work on node-inspect. :)

@Trott
Copy link
Member

Trott commented Jan 23, 2017

Ping @renrutnnej on the "shout-out in the newsletter" request. (Aside: Should @renrutnnej be added to @nodejs/evangelism?)

@jennwrites
Copy link

Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants