-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring 'node-inspect' (CLI Debugger) under the Foundation #190
Comments
I'm +1 on moving forward on this. |
The TSC concluded in yesterday's meeting to bring in node-inspect as proposed, pending agreement from the CTC. I think the next step would be to ask @nodejs/ctc to chime in here or in nodejs/CTC#40 to finalize. @jasnell or @mhdawson can you please label with |
Should we open a new issue for voting or just vote in the already open issue? edit: i'm +1 |
@MylesBorins seems +1's here or in the CTC issue should be sufficient, there are a lot of issues open already :) If we have enough votes in favor in the issues I'll collect them before the next TSC meeting and we can move forward, if not we can bring it up again in the Jan-25 CTC meeting to finalize. Thanks! |
+1 from me! |
At today's CTC meeting, this received additional "yes" votes from @Fishrock123 @addaleax @mscdex @rvagg @bnoordhuis @thefourtheye @jasnell @ChALkeR and @trevnorris. As this already has 3 yes votes from CTC members above (me, @mhdawson, and @MylesBorins), that's 12 yes votes, which is a majority of the CTC. This passes. I'll remove the |
Thanks everyone, especially @jkrems for this donation! @nodejs/evangelism can you perhaps give him a shout-out in the next newsletter? Repo is now available at https://github.com/nodejs/node-inspect 🎉 |
If there's a shout-out in the newsletter, it would be good to also mention @groupon since they sponsored some of my work on node-inspect. :) |
Ping @renrutnnej on the "shout-out in the newsletter" request. (Aside: Should @renrutnnej be added to @nodejs/evangelism?) |
Thanks for the heads up! |
As summarized in nodejs/diagnostics#67, work is underway to replace Node's current built-in CLI debugger (
node debug
) with a new one compatible with the new Inspector Protocol. @jkrems has an implementation at https://github.com/buggerjs/node-inspect and work has begun in nodejs/node#10187 to include this as a third-party dependency under "deps" in nodejs/node.We'll likely also further integrate it into the standard Node binary so that
node debug
ornode inspect
work out-of-the-box as in the past, see nodejs/node#10187 for discussion.Since the CLI debugger is a significant component of Node core, and because we'd like to facilitate broader and deeper work on this basic diagnostic tool, the @nodejs/diagnostics WG recommends that the TSC:
I believe all necessary prerequisites as described in TSC/Project-Lifecycle.md have been completed.
Thanks!
The text was updated successfully, but these errors were encountered: