Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the OpenJS Foundation staff as a billing manager for nodejs-private #1376

Closed
mcollina opened this issue Apr 20, 2023 · 17 comments
Closed

Comments

@mcollina
Copy link
Member

In openjs-foundation/cross-project-council#1009 (comment), @bensternthal offered to set up a virtual credit card to pay for GitHub Actions minutes in nodejs-private.

I think this would allow us to have continuity of service for the security releases.

On a similar note, @abbycabs has offered to bump up nodejs-private up into the waitlist to the large runners for private builds.

Should we move forward?

@richardlau
Copy link
Member

I'm +1 but I have no idea what our budget ask would need to be -- the amount of minutes we'd need is wholly dependent on how often we push to nodejs-private -- every commit triggers the workflows (although subsequent pushes to the same branch does cancel any inflight/queued runs).

@mcollina
Copy link
Member Author

We'll start with 100$ and adjust

@targos
Copy link
Member

targos commented Apr 20, 2023

Can't we ask GitHub for the same free coupon that we have on the nodejs org?

@mcollina
Copy link
Member Author

Unfortunately, that's not available for private repositories.
We already have the maximum allotment they give away for free: we are burning through them too quickly.

@targos
Copy link
Member

targos commented Apr 20, 2023

Another option is to disable the most costly GitHub actions on the private repo (test-asan for example). TBH I'm not sure they are really useful to prepare security releases.

I have no objections to adding some money on the account, though. We'll see how much is needed in practice.

@aduh95
Copy link
Contributor

aduh95 commented Apr 20, 2023

I agree that disabling workflows seems like a more reasonable approach. We can use https://github.com/pricing/calculator to estimate how much money would be actually needed.

Here's what I get if I calculate for a daily run of Coverage Linux + Coverage Windows + test macOS:
screenshot of the GitHub Calculator showing a bill of $339.12

@mhdawson
Copy link
Member

Ouch that MacOS cost is high. In addition to trimming the actions, we may want to change the actions in the private repo so that they only run on request versus on every push. I think we end up with a lot of runs that we don't necessarily need.

@abbycabs
Copy link

Can't we ask GitHub for the same free coupon that we have on the nodejs org?

nodejs-private already has the highest level of coupon we offer (free Enterprise plan) , same as nodejs. This includes 50,000 private minutes / month, which doesn't seem to be sufficient.

I definitely recommend optimizing your actions usage if you can!

There are a couple larger runners betas you can join. They have separate pricing than the standard runners. These are all more powerful machines, so hopefully you would need fewer minutes to complete the build!

Try trimming your actions first, but if you'd like to join either beta let me know when you're on the waitlist & I can flag you in.

@tniessen
Copy link
Member

Related to reducing build times: nodejs/build#2949 (I was going to work on that but didn't find enough time yet)

@mcollina
Copy link
Member Author

I've disabled both Windows and Mac OS X workflows in nodejs-private. Let's see how it goes and reasses.

@mcollina
Copy link
Member Author

DUring the meeting we agreed to add the billing manager with a small budget, ideally 100$. @bensternthal what are the next steps?

@bensternthal
Copy link

Let me seek budget approval for this monthly spend. Once I have approval I can detail next steps here.

@rginn
Copy link

rginn commented May 25, 2023

Approved!

@bensternthal
Copy link

@mcollina can you add me as a billing manager on the right project?

@tniessen
Copy link
Member

@bensternthal Done.

@bensternthal
Copy link

Alrighty, a virtual credit card with a $100 monthly limit has been added.

@mcollina
Copy link
Member Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants