Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not execute the postinstall hook #17

Open
julianduque opened this issue Dec 2, 2013 · 2 comments
Open

Do not execute the postinstall hook #17

julianduque opened this issue Dec 2, 2013 · 2 comments

Comments

@julianduque
Copy link
Contributor

A lot of people use the postinstall hook to execute grunt related tasks and this is being executed on the build server causing issues, we should ignore this hook on our platform

@3rd-Eden
Copy link
Member

3rd-Eden commented Dec 2, 2013

Why not just fix these issues? I can image that a postinstall hook would be used to compile dependencies of browserify packages etc. Removing that could cause issues with apps that actually depend on this hook to be working. Another use case was our handbook, which executed the blacksmith binary in order to build the site
when it got deployed.

@julianduque
Copy link
Contributor Author

So this need to be executed on the drone instead of the build server, ignore postinstall on module-foundry and add it to solenoid instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants