Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Fork me on Github" #33

Open
indexzero opened this issue Jun 30, 2014 · 6 comments
Open

Add "Fork me on Github" #33

indexzero opened this issue Jun 30, 2014 · 6 comments

Comments

@indexzero
Copy link
Member

We should make it clear that this is Open Source on all pages 😄

@alexindigo
Copy link

There are many places where nodejitsu specific parts are hard coded, so it makes it somewhat hard to use as open source product, more like fork and hack on your own thing.

Example:

browsenpm.org:/pages/package.js#L56 -> packages-pagelet:/index.js#L69

Thank you.

@3rd-Eden
Copy link
Member

We could just make this configurable using a configuration file.

@jcrugzz
Copy link
Member

jcrugzz commented Aug 14, 2014

@alexindigo does the registry passed in from the config not work? when a pagelet is extended, it overrides the defaults. Our nodejitsu mirror is just set as the default in the pagelet.

reference

@alexindigo
Copy link

@jcrugzz Actual Registry.mirrors stays intact – https://github.com/3rd-Eden/npmjs/blob/master/index.js#L37-L42

@alexindigo
Copy link

@3rd-Eden Yep, it would help and another problem with dependencies of dependencies that include nodejitsu specific templates, hard to modify things without a lot of forking.
https://github.com/nodejitsu/contour/blob/master/index.js#L11

@3rd-Eden
Copy link
Member

3rd-Eden commented Sep 9, 2014

It's hard to modify templates and designs of a website without forking anyways. That is kinda out of the scope of this project. If you want to use your own styling or templates you can easily build that your self with the various of pagelets that this site is build-upon. But if there are things that would prevent from running this against a different registry etc, I would see it as a bug but as far as I know, it should all be controlled by the configuration file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants