Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken test in node v14 #44

Closed
puzrin opened this issue Nov 3, 2020 · 4 comments
Closed

Broken test in node v14 #44

puzrin opened this issue Nov 3, 2020 · 4 comments

Comments

@puzrin
Copy link
Member

puzrin commented Nov 3, 2020

nodejs/node#35926

Node 14 has regression, failing to interrupt download early. We still can make release with skipped test.

@styxlab
Copy link

styxlab commented Nov 21, 2020

I am using probe-image-size within a Next.js project and identified the package to cause flaky build errors. In the error case, the async probe() never returns and the client finally gives up. This very much looks like the error reported here (I am running on node v14.15.1).

Do you know of a possible workaround? Is it possible to substitute push(null) with something else that ensures the stream is properly terminated? When do you expect the fix to land in node v14?

@puzrin
Copy link
Member Author

puzrin commented Nov 21, 2020

First, try node 15 (it's fixed) to be sure your problems are caused by this bug.

All info about LTS is by link, i can't add more, also waiting for release.

@styxlab
Copy link

styxlab commented Nov 21, 2020

Thanks a lot for the prompt reply. Unfortunately my problem is not solved with v15.2.1, so it must be something else. I may open another issue here. Before, I need to make some more tests in order to verify that the server that is serving the image is not the problem.

puzrin pushed a commit that referenced this issue Dec 17, 2020
@puzrin
Copy link
Member Author

puzrin commented Dec 17, 2020

Fixed in 14.15.2

@puzrin puzrin closed this as completed Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants