Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need help with project support? #220

Closed
glukki opened this issue Jun 12, 2017 · 12 comments
Closed

Need help with project support? #220

glukki opened this issue Jun 12, 2017 · 12 comments

Comments

@glukki
Copy link

glukki commented Jun 12, 2017

Seem like this project need some love and maintenance help.

No updates since December 2016, master branch is broken (yes, with simple typo, but still!).
I use this module in my client's project, so I'm interested in this module staying alive :)

@bergie @pdspicer do you need help? I could become a maintainer

@vvo
Copy link

vvo commented Jul 24, 2017

Seems like https://github.com/auth0/passport-wsfed-saml2 might be a good alternative, anyone tried it?

@vvo
Copy link

vvo commented Jul 24, 2017

Also https://github.com/tngan/samlify

@markstos
Copy link
Contributor

markstos commented Oct 4, 2017

@glukki Considering that there's been response in several months, consider a fork-and-release.

@bergie
Copy link
Contributor

bergie commented Oct 4, 2017

If somebody wants to help maintain, I can give NPM publish rights

@markstos
Copy link
Contributor

markstos commented Oct 4, 2017

I can help push the 0.16 release out, but can't promise much bandwidth on an ongoing basis. I'm also a co-maintainer of the popular node-config module, which has a fairly steady support stream in the issue tracker. My username on NPM is markstos, same as on Github.

@bergie
Copy link
Contributor

bergie commented Oct 4, 2017

@markstos done!

@bergie bergie closed this as completed Oct 4, 2017
@markstos
Copy link
Contributor

markstos commented Oct 4, 2017

@bergie I can confirm that I have NPM publish rights. Could I also have Github commit rights? At the moment I want to push a Github tag so that the release is reflected on Github as well. Thanks.

@josecolella
Copy link
Contributor

@bergie @markstos Is there a need for help for the project?

@markstos
Copy link
Contributor

@josecolella Yes. @bergie is no longer active with the project. I've been helping as the maintainer, but am spread thin with other job responsibilities.

@josecolella
Copy link
Contributor

@markstos I can help with maintaining the project. I think passport-saml is a great library that provides simplicity and ease of use with passport and is easily integrated in projects that use express.

@markstos
Copy link
Contributor

@josecolella Thanks. You are welcome to put together the next potential release in a branch of your own. I'll pledge to do a timely peer-review-merge-and-release once that's done. My bar for quality includes:

  • For any spec-related change, reference the specific place in the SAML spec that discusses the topic.
  • Update documentation where appropriate and update automated tests when feasible.

I'm mindful that an exploit in passport-saml could have a big impact, so I pay close attention to any changes that appear that they could have security implications.

If the collaboration goes well, perhaps @bergie could provide direct commit access (I can't).

@markstos
Copy link
Contributor

Last time I looked at NPM stats, this module was still the #1 SAML solution for Node.js.

Some people are already using it without also using Passport, and I think it would benefit from completing the de-coupling and putting the core SAML functionality in it's own library, released separately.

I think that could attract more users and hopefully then more contributors. It could also help with security: "with enough eyeballs, all bugs are shallow".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants