Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.query ignored when making a request with no query string #610

Closed
flushentitypacket opened this issue Jul 8, 2016 · 4 comments
Closed

.query ignored when making a request with no query string #610

flushentitypacket opened this issue Jul 8, 2016 · 4 comments

Comments

@flushentitypacket
Copy link

This test was removed way back in 3.0.0:
5eb5e2e#diff-ae3b1775e1016e4912805bd8eb567550L4188

I don't know whether that functionality was removed on purpose, but to me it seems completely counter-intuitive to match a scope specifying a query when none is given.
@charlierudolph
Copy link

Just ran into this as well. Agree this is counter-intuitive.

@benbuckman
Copy link
Contributor

👍 I just ran into this too and it seems like a bug.

benbuckman added a commit to Shyp/nock that referenced this issue Sep 29, 2016
@benbuckman
Revert tests from 5eb5e2e. For nock#610.
bfdffd7
benbuckman added a commit to Shyp/nock that referenced this issue Sep 29, 2016
@benbuckman
Add back and fix 'query() will not match when the path has no query' …
be15337 
…test.

see nock#610
@benbuckman benbuckman mentioned this issue Sep 29, 2016
Closed
@galenus
Copy link

galenus commented Feb 13, 2017

What's happening with this bug?

@ianwsperber ianwsperber added this to the Bug catchup milestone Feb 13, 2017
@ianwsperber ianwsperber mentioned this issue Feb 13, 2017
Merged
ianwsperber added a commit that referenced this issue Feb 23, 2017
@ianwsperber
9.0.7: Fix for #610
588aef9
@renovate-bot renovate-bot mentioned this issue Feb 23, 2017
Merged
@lock
Copy link

lock bot commented Sep 13, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@benbuckman @flushentitypacket @charlierudolph @galenus @ianwsperber