Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Change the "maxLength" route registration syntax #8

Open
amitguptagwl opened this issue Oct 7, 2018 · 2 comments
Open

Change the "maxLength" route registration syntax #8

amitguptagwl opened this issue Oct 7, 2018 · 2 comments
Labels
first-timers-only good first issue Good for newcomers help wanted Extra attention is needed

Comments

@amitguptagwl
Copy link
Member

amitguptagwl commented Oct 7, 2018

A route can be registered with the following syntax

- route: 
    uri: "/list/transactions/:creditCard(:credit-card:)"
    maxLength: 1024 * 1024
    to: CreditCardService
    after: [ authentication, monitoring ]
    then: compress

To improve readability, we want to change the framework to support following syntax

A route can be registered with the following syntax

- route: 
    uri: "/list/transactions/:creditCard(:credit-card:)"
    with:
        maxLength: 1024 * 1024
    to: CreditCardService
    after: [ authentication, monitoring ]
    then: compress

Check routesManager to find the relevant code. Please updates the tests accordingly.

@amitguptagwl amitguptagwl added help wanted Extra attention is needed good first issue Good for newcomers first-timers-only labels Oct 7, 2018
@arialdyscv
Copy link

@amitguptagwl is this still available? would like to contribute for hacktoberfest :)

@amitguptagwl
Copy link
Member Author

Thanks @arialdyscv for your interest. I'm not maintaining this code from a long time. Many issues needs to be fixed. But you want to give it a try, go ahead.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
first-timers-only good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants