Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing Action Alerts results in bad page #1

Closed
salsus opened this issue Feb 19, 2013 · 2 comments
Closed

Editing Action Alerts results in bad page #1

salsus opened this issue Feb 19, 2013 · 2 comments
Assignees
Labels
Milestone

Comments

@salsus
Copy link

salsus commented Feb 19, 2013

Clicking the plugin to edit an Action Alert results in an empty page with only "Finish" and "Save" buttons.

Example:
Clicking the plugin from here: https://support.worldwildlife.org/site/Advocacy?cmd=display&page=UserAction&id=687

Results in the following URL:
https://secure2.convio.net/wwf/admin/AdvocacyAdmin?advocacy=alertPageConfigPage.edit_alert_config_pages&advocacyPageType=takeActionBeanPage&alert_id=687&isBeanPage=true

Expected URL:
https://secure2.convio.net/wwf/admin/AdvocacyAdmin?advocacy=alertBeanPageEditor.edit_alert_config_pages&isBeanPage=true&alert_id=687&advocacyPageType=takeActionBeanPage

@ghost ghost assigned noahcooper Feb 20, 2013
@noahcooper
Copy link
Owner

The issue here is that every Action Alert page except the Take Action Page uses the query parameter advocacy=alertPageConfigPage.edit_alert_config_pages, so currently this value is hardcoded in the buildAdminUrl function.

var buildAdminUrl = function(advocacyPageType, additionalArgs) {
  return '?advocacy=alertPageConfigPage.edit_alert_config_pages&advocacyPageType=' + advocacyPageType + 
           '&alert_id=${alertId}' + ((additionalArgs) ? additionalArgs : '');
};

This function needs to be updated to accept an additional argument for the advocacy parameter so it can be set to "alertBeanPageEditor.edit_alert_config_pages" on the Take Action Page.

@noahcooper
Copy link
Owner

Fixed in v1.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants