Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] - Championship / Consolation overview does not consider 2 Weeks Playoff setting #97

Closed
Justatix opened this issue Dec 20, 2021 · 3 comments · Fixed by #113
Closed

[BUG] - Championship / Consolation overview does not consider 2 Weeks Playoff setting #97

Justatix opened this issue Dec 20, 2021 · 3 comments · Fixed by #113
Assignees
@nmelhado
Labels
bug Something isn't working

Comments

@Justatix
Copy link

Describe the bug
The Playoffs / Consolation Overview on the League Page is not considering the Playoffs setting of 2 Weeks. it only shows the 1 week result of it.

Your League ID
692769447512989696

Expected behavior
The aggregated sum of 2 games should be displayed in the playoff/consolation bracket

Screenshots
Bildschirmfoto 2021-12-20 um 12 13 28
Bildschirmfoto 2021-12-20 um 12 13 42

Desktop (please complete the following information):

  • OS: macOS 12.1
  • Browser Safari
  • Version 15.2

Additional context
Add any other context about the problem here.
@Justatix Justatix added the bug Something isn't working label Dec 20, 2021
@Justatix Justatix changed the title [BUG] [BUG] - Championship / Consolation overview does not consider 2 Weeks Playoff setting Dec 20, 2021
@nmelhado
Copy link
Owner

nmelhado commented Jan 3, 2022

Going to try to tackle this, but will have to be fixed for next season at this point. Sorry I wasn't able to get to this for this season.

@Justatix
Copy link
Author

Justatix commented Jan 3, 2022

no worries, there's no urgency in that. glad you'd take this up, thanks for your effort!

@nmelhado nmelhado linked a pull request Apr 13, 2022 that will close this issue
render league brackets correctly for two weeks per round leagues #113
Merged
@nmelhado
Copy link
Owner

Fixed in #113! Should be good to go for next season

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nmelhado nmelhado

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

render league brackets correctly for two weeks per round leagues nmelhado/league-page
2 participants
@nmelhado @Justatix