-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Standings are pulling division record into overall record #276
Comments
I will second this happening. Because it says I have 6 wins in the json pulled from sleeper not 3 plus 3 median wins. Then it is adding another median win to the win total pulled from Sleeper possibly? I am curiuos if we need to shut off the median scoring comparisons inside the league-page modules all together? Your stuff is fantastic as stated above though! Just trying to do some customizing and noticing this as well. I have not decided about the divisions yet, but at first glance I don't think mine is pulling the division wins separtely and counting them in the total. But it is counting the overall wins pulled from sleeper which is 6 for 3 weeks as undefeatd but it gives me 9 wins on the standings pages... and stepping through it in the leagueStandings.js I can console.log out these lines and see it happening I think. ` if (medianMatch == true) {
|
And to follow up - I just did this:
and it made it all accurate, so I think what was happening was Sleeper wasn't allowing us to play vs the median when this oriignal code base was designed and written and he built into the median comparison. Now that sleeper includes that in our wins it doubles those in the outcome of the leagueStandings.js I think. |
I just went in and added the "false; //" and it looks like everything is fixed. Thank you for diving into it! |
Sure thing. But that ruins the league-page's code for figuring out records and all time matchups and such so far! |
My league uses median scoring and has different divisions. After Week 2, it says the top team is 6-0 (2-0 from H2H, 2-0 from median scoring, but it is also being counted 2-0 from beating a division opponent). I like having the divisions standings as a separate stat, but it should not be included in the overall record which should be 4-0.
On a separate issue, all the season averages are pulling from the 6 games it's saying is played instead of just the 2 weeks that have been played.
I hope all this makes sense, I love your work man~!!
The text was updated successfully, but these errors were encountered: