Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make json_benchmarks no longer working in 2.0.4 #310

Closed
whackashoe opened this issue Sep 13, 2016 · 2 comments
Closed

make json_benchmarks no longer working in 2.0.4 #310

whackashoe opened this issue Sep 13, 2016 · 2 comments

Comments

@whackashoe
Copy link
Contributor

$ make json_benchmarks 
cd benchmarks/files/numbers ; python generate.py
g++ -std=c++11  -DNDEBUG -O3 -flto -I src -I benchmarks benchmarks/benchmarks.cpp  -o json_benchmarks
./json_benchmarks
parse jeopardy.json                           1  2970652448 ns/op
parse canada.json                            50    44576518 ns/op
parse citm_catalog.json                      50    22833206 ns/op
parse twitter.json                          100    12558957 ns/op
terminate called after throwing an instance of 'std::invalid_argument'
  what():  parse error - unexpected end of input; expected ']'
make: *** [json_benchmarks] Aborted
make: *** Deleting file `json_benchmarks'

2daab5a is culprit.

@nlohmann
Copy link
Owner

After reading a line from a stream, the newline symbol was added at the wrong place. The issue is fixed. The fix shall be released as 2.0.5.

@nlohmann nlohmann self-assigned this Sep 14, 2016
@nlohmann nlohmann added this to the Release 2.0.5 milestone Sep 14, 2016
@nlohmann
Copy link
Owner

Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants