Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a new eta parameter "estimate" / "middle value" / "average" #207

Open
Staubgeborener opened this issue Oct 14, 2022 · 3 comments
Open
Assignees
Labels
Feature Request New feature or request

Comments

@Staubgeborener
Copy link

Staubgeborener commented Oct 14, 2022

What would you like to see added?

Right now the only possible eta values are slicer or file:

[telegram_ui]
#eta_source: slicer
#	You can choose, which value to use for remaining time estimation.
#	Default value is slicer.
#	Allowed values: slicer, file

Klipper can calculate a third eta value based on the middle value of filament and file. In my case, this is one of the most presicely eta calculation i can get. While slicer eta time shows me a value of 0:05:35, the average value of file (0:09:44) and filament (0:03:20) give me a eta value of 0:06:32 which is in fact accurate to the second.

Maybe it's a opportunity to add a third value filament to the moonraker-telegram-bot and let the user decide which numbers should be combined and determine the average value from this. Like, adding multiple values leads to a average calculation: eta_source: file, filament

image

@Staubgeborener Staubgeborener added the Feature Request New feature or request label Oct 14, 2022
@aka13-404
Copy link
Collaborator

Thank you for writing such a detailed feature request, it's so refreshing :)
What I am wondering though, I have not had time to check, are you sure it's a klipper thing?
The slicer and filament variables are pulled from moonraker, we do not touch them ourselves.

Is this "middle" thing a new addition which we missed? If it is, adding it should be easy. If it is not, I am not sure if we want to add it. We want to keep the amount of calculations/things we do ourselves to a necessary minimum, because the bot is not an active component of the ecosystem, but rather a displaying/controlling entity.

@Staubgeborener
Copy link
Author

Staubgeborener commented Oct 18, 2022

I can't tell you if this calculation is from klipper or moonraker. Maybe it's a mainsail related feature? In my setup, I am using klipper with mainsail. In mainsail you can go to settings and there is a section for eta. Mainsail ask on which base the eta should be calculated and you can choose between different sources (file, filament, slicer). At exactly this step you can also choose more than one source to calculate an average value.

@aka13-404 aka13-404 self-assigned this Oct 26, 2022
@CODeRUS
Copy link
Contributor

CODeRUS commented Nov 3, 2022

see: https://github.com/mainsail-crew/mainsail/blob/develop/src/store/printer/getters.ts#L1013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants