Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component feature request: footer with border and column-layout #2555

Open
AlineNap opened this issue Oct 9, 2024 · 3 comments
Open

Component feature request: footer with border and column-layout #2555

AlineNap opened this issue Oct 9, 2024 · 3 comments

Comments

@AlineNap
Copy link

AlineNap commented Oct 9, 2024

Please add tokens to be able to place a border at the top of the page footer and to add a column layout. The following tokens are involved:

  • utrecht.page-footer.border-color
  • utrecht.page-footer.border-width
  • utrecht.page-footer.content.column-gap
  • utrecht.page-footer.content.max-inline-size
  • utrecht.page-footer.content.column-width
  • utrecht.page-footer.content.row-gap

During the RHC sprint planning on October 2nd, Robbert confirmed that this can be added to the Utrecht code.

@AlineNap
Copy link
Author

AlineNap commented Oct 9, 2024

Zie meer info in ticket van RHC: nl-design-system/rijkshuisstijl-community#727
En het design voor lux (mijn aansluitingen) hier: https://www.figma.com/design/jzxqJv4PtgHJdmOJwY6lYg/NLDS---Bibliotheek---LUX-tokens?node-id=15613-2989

@Robbert
Copy link
Member

Robbert commented Oct 9, 2024

Voorbeeld:

.utrecht-page-footer__content {
  --utrecht-column-layout-column-gap: var(--utrecht-page-footer-content-column-gap);
  display: flex;
  column-gap: var(--utrecht-page-footer-content-column-gap);
}

@JoeriRoijenga
Copy link

@AlineNap is this a relevant issue for us (RijksHuisstijl) or should this be handled by Utrecht?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants