Getting null pointer exception with basic configuration because of missing user mapping file and options

[CBuntrock]

Hi everyone,

I started a simple test project with basic configuration using 16.0.8 and noticed I am getting null reference exception. According to the Stacktrace it seems to me ValidateAllUsersExistOrAreMapped is always called but without the option for user mappings configured it probably cannot get the identities or their fields?
Side question: Is it "ok" to migrate without user mappings or does it lead to problems in the target?

Best,
Chris

System.NullReferenceException: Object reference not set to an instance of an object.
at MigrationTools.Processors.TfsWorkItemMigrationProcessor.ValidateAllUsersExistOrAreMapped(List`1 sourceWorkItems) in D:\a\azure-devops-migration-tools\azure-devops-migration-tools\src\MigrationTools.Clients.TfsObjectModel\Processors\TfsWorkItemMigrationProcessor.cs:line 232
at MigrationTools.Processors.TfsWorkItemMigrationProcessor.InternalExecute() in D:\a\azure-devops-migration-tools\azure-devops-migration-tools\src\MigrationTools.Clients.TfsObjectModel\Processors\TfsWorkItemMigrationProcessor.cs:line 130
at MigrationTools.Processors.Infrastructure.Processor.Execute() in D:\a\azure-devops-migration-tools\azure-devops-migration-tools\src\MigrationTools\Processors\Infrastructure\Processor.cs:line 99

[RubyDoma]

I'm having the same issue, any help is appreciated thanks

[MrHinsh]

You dont need to add user mappings... they are in addition. Looks like we introduced an unessarary dependency in 16.0.8.. you can use 16.0.7 or you can enable the user mapping and don't set a file... Ill raise a bug.

[MrHinsh]

@satano, do you have an idea... its likely from the work that you did in this area.

[MrHinsh]

@satano found it... we have:

 private void ValidateAllUsersExistOrAreMapped(List<WorkItemData> sourceWorkItems)
 {
     contextLog.Information("Validating::Check that all users in the source exist in the target or are mapped!");
     IdentityMapResult usersToMap = CommonTools.UserMapping.GetUsersInSourceMappedToTargetForWorkItems(this, sourceWorkItems);
     if (usersToMap.IdentityMap != null && usersToMap.IdentityMap.Count > 0)
     {
         Log.LogWarning("Validating Failed! There are {usersToMap} users that exist in the source that do not exist "
             + "in the target. This will not cause any errors, but may result in disconnected users that could have "
             + "been mapped. Use the ExportUsersForMapping processor to create a list of mappable users.",
             usersToMap.IdentityMap.Count);
     }
 }

But usersToMap is null is its disabled...

[MrHinsh]

Should be fixed with #2545