New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApacheConnectionPool's testWhileIdle is false and not configurable #23

Open

tachim opened this issue Aug 26, 2011 · 0 comments

tachim commented Aug 26, 2011

On line 55 of https://github.com/nkallen/querulous/blob/master/src/main/scala/com/twitter/querulous/database/ApachePoolingDatabase.scala, config.testWhileIdle is set to false. According to http://commons.apache.org/pool/apidocs/org/apache/commons/pool/impl/GenericObjectPool.html, this means that timeBetweenEvictionRunsMillis has no effect, the connections are never checked when idle, and the pool sometimes returns invalid connections.

Is there a reason to not let this be configurable (or at least default to true)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment