Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: guide = FALSE is deprecated | use guide = "none" instead #288

Closed
ddauber opened this issue Aug 11, 2021 · 4 comments
Closed

Warning: guide = FALSE is deprecated | use guide = "none" instead #288

ddauber opened this issue Aug 11, 2021 · 4 comments

Comments

@ddauber
Copy link

ddauber commented Aug 11, 2021

Hi there! 👋


Please see the warning issued below when running gg_miss_var().

This warning does NOT show up with functions like:

  • gg_miss_case
  • gg_miss_var_cumsum()
  • gg_miss_case_cumsum()

(I have not tested all functions 😉)

It seems like an easy fix, though.

df <- dplyr::tribble(
  ~x, ~y,
  1,   1,
  2,  NA,
  NA,  3
  )

naniar::gg_miss_var(df)
#> Warning: It is deprecated to specify `guide = FALSE` to remove a guide. Please
#> use `guide = "none"` instead.

@njtierney
Copy link
Owner

Hi @ddauber !

Thanks so much for that, that is a relatively easy fix - about to push now.

@ddauber
Copy link
Author

ddauber commented Oct 5, 2021

It seems this issue was resolved with ede9539. 👍

@ddauber ddauber closed this as completed Oct 5, 2021
@njtierney
Copy link
Owner

Sorry I didn't get back to you - thanks for posting a great reprex! :)

@ddauber
Copy link
Author

ddauber commented Oct 6, 2021

No problem at all. We are all busy people.👨‍💻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants