Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The function is_stable() is misnamed. #219

Open
karnigen opened this issue Dec 20, 2024 · 0 comments
Open

The function is_stable() is misnamed. #219

karnigen opened this issue Dec 20, 2024 · 0 comments

Comments

@karnigen
Copy link

karnigen commented Dec 20, 2024

I believe there is a naming inconsistency with the function is_stable(). Currently, it returns true for unstable nuclides, which is counterintuitive. A more logical behavior would be to return true for stable nuclides and false for unstable ones.

I suggest renaming the function to is_unstable() to better reflect its current behavior. Alternatively, we could keep the name is_stable() but invert the return values.

Python is_stable() wraps c++ isStable() that simply returns STA of MF=1 MT=451.
Meaning of STA from ENDF documentation 1.1.

STA Target stability flag:

  • STA=0, stable nucleus;
  • STA=1 unstable nucleus. If the target is unstable, radioactive decay data should be given in the decay data sub-library (NSUB=4).

The isStable() function returns true for stable nuclids for MF=8 MT=457, as expected (returns NST).
It's counterproductive to receive inconsistent results from the same function in different environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant