From 5f6d901971820a119a62662287331f9295fcbc22 Mon Sep 17 00:00:00 2001 From: Joe Peterson Date: Mon, 14 Oct 2024 16:00:59 -0600 Subject: [PATCH] Fixing issue in bash script to check error code in memleak ci --- .github/scripts/prep_valgrind_test.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/scripts/prep_valgrind_test.sh b/.github/scripts/prep_valgrind_test.sh index e8e26388..379413c3 100644 --- a/.github/scripts/prep_valgrind_test.sh +++ b/.github/scripts/prep_valgrind_test.sh @@ -1,7 +1,7 @@ #! /bin/bash echo " check_return_code() { - if [ $? -ne 0 ]; then + if [ /$? -ne 0 ]; then echo \"Memory leak detected. Test Failed...\" exit 1 fi @@ -12,6 +12,6 @@ check_return_code() { find . -iname "*.test" -type f | while IFS= read -r line; do dirname=$(dirname "$line") realname=$(basename "$line") - echo "cd ${dirname}; valgrind --leak-check=full --show-leak-kinds=all --error-exitcode=1 ./${realname}; check_return_code; cd -" >> test_valgrind.sh + echo "cd ${dirname}; valgrind --leak-check=full --show-leak-kinds=all --errors-for-leak-kinds=all --error-exitcode=1 ./${realname}; check_return_code; cd -" >> test_valgrind.sh done