20.09: loaOf in users.users and users.groups makes nixcloud-webservices throw an error

[fgaz]

In 20.03 it just gave a warning:

trace: warning: In file /nix/store/kqx95nfx4wafnzxkiyjnr6xdj9mfpsdn-nixos-20.03.tar.gz/nixos/modules/config/users-groups.nix
a list is being assigned to the option config.users.users.                                                                              
This will soon be an error as type loaOf is deprecated.                                                                                 
See https://github.com/NixOS/nixpkgs/pull/63103 for more information.                                                                   
Do                                                                                                                                      
  users.users =                                                                                                                         
    { reverse-proxy = {...}; }                                                                                                          
instead of                                                                                                                              
  users.users =                                                                                                                         
    [ { name = "reverse-proxy"; ...} ]                                                                                                  
                                                                                                                                        
trace: warning: In file /nix/store/kqx95nfx4wafnzxkiyjnr6xdj9mfpsdn-nixos-20.03.tar.gz/nixos/modules/config/users-groups.nix
a list is being assigned to the option config.users.groups.                                                                             
This will soon be an error as type loaOf is deprecated.                                                                                 
See https://github.com/NixOS/nixpkgs/pull/63103 for more information.                                                                   
Do                                                                                                                                      
  users.groups =                                                                                                                        
    { reverse-proxy = {...}; }                                                                                                          
instead of                                                                                                                              
  users.groups =                                                                                                                        
    [ { name = "reverse-proxy"; ...} ] 

But in 20.09 the old type was removed and this results in an error.

To reproduce, set nixcloud.reverse-proxy.enable = true

edit: same error in other places later in the evaluation

[fgaz]

Found two of them:

nixcloud-webservices/modules/services/reverse-proxy/default.nix

Lines 396 to 403 in 05701ee

	users.extraUsers = (singleton
	{ name = "${user}";
	group = "${group}";
	});
	users.extraGroups = (singleton
	{ name = "${user}";
	});

Now looking for the others. I'll open a pr with the fixes.

I wish we had static typing. It would make everything much easier

[fgaz]

#73