Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.10.0 #791

Closed
asomers opened this issue Nov 5, 2017 · 10 comments
Closed

Release 0.10.0 #791

asomers opened this issue Nov 5, 2017 · 10 comments
Milestone

Comments

@asomers
Copy link
Member

asomers commented Nov 5, 2017

It's been more than three months since a release. Let's do another. The most important things to include IMHO are PR #790 because it fixes a build failure with newer versions of libc, and issue #788 because it's a backwards incompatible change. We want to release #788 as soon as possible to minimize the number of affected users.

Add milestone 0.10.0 markers to any other issues or PRs that you think must be included.

@asomers asomers added this to the 0.10.0 milestone Nov 5, 2017
@Susurrus
Copy link
Contributor

Susurrus commented Nov 5, 2017

I'd suggest we also modify our release procedure a little here. We have 3 things tracking this release, this issue, the milestone, and then tags for issues. The tags and the milestone are redundant, since things targetting a specific milestone have visual indicators. And the milestone itself can contain a description, much like you provided one here.

I'd also propose that whatever we figure out about this procedure gets updated in RELEASE_PROCEDURE.md.

@Susurrus
Copy link
Contributor

@asomers I'd like to make the 0.10 release happen soon here as it updates up to bitflags 1.0, which is ended up being a big breaking change throughout the ecosystem, so I'd like us to be in sync with that. Any progress on #788? Or do you know when you might be able to get to it?

@asomers
Copy link
Member Author

asomers commented Dec 19, 2017

Yeah, I've got #788 working. But before I submit a PR I want to make sure that everything is hunky-dory in the dependent crates too. Hopefully I can find some time during the holidays to finish it.

@Susurrus
Copy link
Contributor

@asomers I'm deferring to you as the release manager what the next steps are. I think we're ready for a release. I'd also suggest we use cargo-release instead of the process outlined in RELEASE_PROCEDURE.md, as it's quick and should minimize manual errors. As part of that, I'd suggest we update that document as well so it can be relied on (I'd also like to link to it from our README in some way that is supported by GitHub and crates.io ideally).

@asomers
Copy link
Member Author

asomers commented Jan 26, 2018

Completed by PR #844 and PR #845 . I didn't use cargo-release, because that doesn't take care of updating our CHANGELOG and README files. It isn't clear how to do those in combination with cargo-release.

@asomers asomers closed this as completed Jan 26, 2018
@Susurrus
Copy link
Contributor

Then I'd suggest we file a bug with cargo-release as it'd be nice for us to have a simpler release process.

I'd also be curious if we could cut down on the steps we do that involve bors, as that can be a pain with Travis' Mac builds.

@asomers
Copy link
Member Author

asomers commented Jan 26, 2018

Instead of cutting down on bors, how about we cut down on Travis instead? Is there a way to tell Travis not to bother building a PR if the only changed files are pure documentation, like the README?

@posborne
Copy link
Member

Instead of cutting down on bors, how about we cut down on Travis instead? Is there a way to tell Travis not to bother building a PR if the only changed files are pure documentation, like the README?

I doubt there is anything builtin to do this. You would have to look at the diff and terminate early if you thought that change was not worth testing. Here's one example I was able to find (on react) that does this: https://github.com/facebook/react/pull/2000/files

@asomers
Copy link
Member Author

asomers commented Jan 26, 2018

It's a little more manual, but it looks like we can tell Travis not to build something by putting [ci skip] in the commit message. https://docs.travis-ci.com/user/customizing-the-build/

@Susurrus
Copy link
Contributor

There isn't yet, but Appveyor has it, so that's cool. See travis-ci/travis-ci#6301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants