Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delay activation #424

Merged
merged 2 commits into from
Sep 20, 2024
Merged

feat: delay activation #424

merged 2 commits into from
Sep 20, 2024

Conversation

QuarticCat
Copy link
Contributor

Fix #423

This PR changes activationEvents from onStartupFinished to onLanguage:nix. And starting from VSCode 1.74, onLanguage events will be generated automatically. So we can simply leave it blank.

Reference: https://code.visualstudio.com/api/references/activation-events#onLanguage

@jnoortheen jnoortheen merged commit 7038804 into nix-community:main Sep 20, 2024
4 checks passed
@jnoortheen
Copy link
Collaborator

Thanks @QuarticCat !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delay extension startup until a Nix file is opened
2 participants