feat: support use vscode variables in settings #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njzydark
force-pushed
the
feat-support-vscode-variables
branch
from
0920035 to
9e7320c
Compare
jnoortheen
reviewed
Jun 13, 2024
| export default function variables( | ||
| string: string, | ||
| recursive?: boolean, | ||
| ): string; |
There was a problem hiding this comment.
do we need to export these types? is this needed by vscode ?
There was a problem hiding this comment.
This type definition is mainly for solving type checking issues.
jnoortheen
reviewed
Jun 13, 2024
use vscode-variables package to support using ${workspaceFolder} in configuration files to define paths
njzydark
force-pushed
the
feat-support-vscode-variables
branch
from
9e7320c to
92dcfca
Compare
njzydark
commented
Jun 13, 2024
| @@ -73,6 +73,10 @@ Pass settings to the language server via the `serverSettings` option. | |||
| }, | |||
| "home-manager": { | |||
| "expr": "(builtins.getFlake \"/absolute/path/to/flake\").homeConfigurations.<name>.options" | |||
| }, | |||
| // Tip: use ${workspaceFolder} variable to define path | |||
There was a problem hiding this comment.
describe this feature here
jnoortheen
approved these changes
Aug 2, 2024
|
Thanks for the contribution @njzydark ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/nix-community/nixd/blob/main/nixd/docs/configuration.md#where-to-place-the-configuration
According to the above document, when defining the expr of options, only absolute paths can be used. This is very inconvenient for configuring across machines. Therefore, this PR introduces the vscode-variables package to support using
${workspaceFolder}in configuration files to define paths.before
{ "nixd": { "options": { "nixpkgs": { "expr": "import <nixpkgs> { }" }, "nix-darwin": { "expr": "(builtins.getFlake \"/absolute/path/to/flake\").darwinConfigurations.default.options" } } } }after
{ "nixd": { "options": { "nixpkgs": { "expr": "import <nixpkgs> { }" }, "nix-darwin": { "expr": "(builtins.getFlake \"${workspaceFolder}/flake\").darwinConfigurations.default.options" } } } }