Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch error if serverPath doesn't exist #267

Merged
merged 1 commit into from
Aug 16, 2022
Merged

fix: catch error if serverPath doesn't exist #267

merged 1 commit into from
Aug 16, 2022

Conversation

hall
Copy link
Collaborator

@hall hall commented Aug 16, 2022

These changes fix the command-exists function usage such that the extension doesn't fail to activate if enableLanguageServer is true and serverPath is not in $PATH; which currently throws the following error:

Screenshot from 2022-08-15 21-00-25

With the changes in this PR, the error is properly handled:

Screenshot from 2022-08-15 21-01-03

Fixes #203.

@hall hall requested a review from jnoortheen August 16, 2022 01:16
@jnoortheen jnoortheen merged commit 95caf81 into nix-community:main Aug 16, 2022
@jnoortheen
Copy link
Collaborator

Thanks @hall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not load with Remote SSH connection
2 participants