fix: LORRI_READDIR was never used
#134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just1602
force-pushed
the
use-lorri-readdir
branch
from
65d003b
to
5d88cd4
Compare
When inside the `lazy_static` block, rust-analyzer was not able to detect if a variable was ever used or not, but since b2a6499 rust-analyzer point out that `LORRI_READDIR` regex was never used. This commit make the if use `LORRI_READDIR` before calling `LogDatum::ReadDir`.
just1602
force-pushed
the
use-lorri-readdir
branch
from
5d88cd4
to
304f9b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inside the
lazy_staticblock, rust-analyzer was not able to detect if a variable was ever used or not, but since b2a6499 rust-analyzer point out thatLORRI_READDIRregex was never used.This commit make the if use
LORRI_READDIRbefore callingLogDatum::ReadDir.As the previous PR, this one is based on #132 , and #133, so those need to be merged first. :)
release.nix(seerelease.nixfor instructions)