Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: add a note that shell integrations should not be just completions #6441

Open
ambroisie opened this issue Feb 12, 2025 · 2 comments

Comments

@ambroisie
Copy link
Contributor

ambroisie commented Feb 12, 2025

A lot of PRs that I review which try to add shell integration options are only used for packages to install their shell completion, which should instead be done as part of packaging in nixpkgs, rather than in home manager.

A few examples from recent memory:

We should explicitly document that a shell integration which only installs a program's completion is not necessary, and should instead be properly packaged in nixpkgs.

@boomshroom
Copy link

What should be done for packages that provide completions for shells other than bash, zsh, and fish? Home-manager supplies integrations for nushell for several packages, however nixpkgs only installs shell completions for the big three. That's not to mention other shells like elvish and powershell that some packages provide completions for, but are supported by neither home-manager nor nixpkgs.

@ambroisie
Copy link
Contributor Author

In my opinion those should all be packaged in nixpkgs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants