-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: per pkgs updateScript #468
base: main
Are you sure you want to change the base?
Conversation
433c423
to
1de8485
Compare
I introduced the $ ./maintainers/scripts/update.sh With the latest version of our update.sh script we have the following output: framework :: Dev/nix-community/ethereum.nix ‹feat/per-pkg-update-script*› % ./maintainers/scripts/update.sh 1 ↵
++ git rev-parse --show-toplevel
+ rootDir=/home/aldo/Dev/nix-community/ethereum.nix
++ nix eval --raw -f /home/aldo/Dev/nix-community/ethereum.nix inputs.nixpkgs.outPath
+ nixpkgs=/nix/store/j8han9cf3g8vba52yhiklaa6a500pcbv-source
++ nix eval --raw -f /home/aldo/Dev/nix-community/ethereum.nix
+ flake=/nix/store/xkkzpgjfzg0k9kny36lckf0ckbw7vc1h-source
+ nix-shell --show-trace /nix/store/j8han9cf3g8vba52yhiklaa6a500pcbv-source/maintainers/scripts/update.nix --arg include-overlays '[(import /home/aldo/Dev/nix-community/ethereum.nix).overlays.default]' --arg keep-going true --arg predicate '(
let
prefix = "/nix/store/xkkzpgjfzg0k9kny36lckf0ckbw7vc1h-source/pkgs/";
prefixLen = builtins.stringLength prefix;
in
(path: pkg: (builtins.substring 0 prefixLen pkg.meta.position) == prefix)
)'
trace: warning: libsForQt5 now uses makeScopeWithSplicing which does not have "overrideScope'", use "overrideScope".
this derivation will be built:
/nix/store/d8q0cq5b8f82cqrdhpl6zc6qz8g2rab2-packages.json.drv
building '/nix/store/d8q0cq5b8f82cqrdhpl6zc6qz8g2rab2-packages.json.drv'...
Going to be running update for following packages:
- charon-0.18.0
- dirk-1.2.0
- dreamboat-0.4.20
- eigenlayer-0.5.0
- erigon-2.57.0
- eth2-testnet-genesis-0.9.0
- eth2-val-tools-0.1.1
- ethdo-1.35.2
- ethereal-2.8.10
- geth-1.13.11
- geth-sealer-geth-sealer-v1.13.4
- heimdall-rs-0.7.3
- mev-boost-1.6.0
- builder-1.11.5-0.3.0
- mev-boost-relay-0.27.0
- prysm-4.2.1
- rocketpool-1.11.7
- sedge-1.2.3
- python3.11-slither-0.10.0
- ssv-1.2.2
- staking-deposit-cli-2.7.0
- teku-23.10.0
- tx-fuzz-1.3.2
- vouch-1.7.6
- python3.11-eth-wake-4.3.0
- zcli-0.6.0
Press Enter key to continue... More refinements are necessary, probably I'll port the logic to |
7d3a010
to
3a6cc80
Compare
OK, the first step of tests is looking promising as I've been able to perform updates on each package quite fast. I'll allocate whatever time I have left this week and separate it into a standalone Python binary instead. |
Really cool work! for filtering releases for #476 we can use the approach with For example, for $ nix-update --flake mev-boost-prysm --version-regex '(v\d+\.\d+\.\d+$)'
...
Update 4.0.0-boost0.2.0 -> 3.2.0 We also had the same problem with lighthouse until For vouch it can recognize the stable release, so we can use just $ nix-update --flake vouch --version=unstable
...
Update 1.7.6 -> 1.8.0-beta.3 But small question, I thought I would use the original It's really impressive and much more than I thought about that, we can move that login to |
Resuming work again! I was busy these past two weeks with my newborn son!
I had different ideas and was still unsure of the best approach when I was exploring the other day. But whilst I was using the My latest way of thinking is just to improve the
Correct. You got the idea very well :) |
089c10d
to
3542104
Compare
3542104
to
1fb43dc
Compare
Rebased to main + comment some problem packages for now. @aldoborrero what do you think if we merge it as is and will continue to improve them via other PRs? It helps us to update all packages which isn't update right now |
@brianmcgee also fyi |
@selfuryon Yeah go ahead. I never published the stand-alone version I was working on to separate the tool. |
This PR introduces the
passthru.updateScript
for having custom-tailored update scripts per pkg.The attempt is to refactor / improve our existing
nix-update-action
workflow (for now highly experimental).@selfuryon just making you aware of my intentions so we can work/hack together on this.
To call the update:
Closes #469