Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudflare-module): use correct types for email and queue events/hooks #2710

Closed
wants to merge 1 commit into from

Conversation

zsilbi
Copy link
Contributor

@zsilbi zsilbi commented Sep 5, 2024

πŸ”— Linked issue

Original issue: #2480

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)

πŸ“š Description

#2487 introduced custom types for these events and hooks that contain typos. (for example: adk() instead of ack())

There are native types provided by @cloudflare/workers-types that we can use for these.
I updated the exported handler and the hooks accordingly.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@zsilbi zsilbi changed the base branch from main to v2 September 5, 2024 11:53
@zsilbi zsilbi changed the base branch from v2 to main September 5, 2024 11:54
@zsilbi zsilbi changed the base branch from main to v2 September 5, 2024 11:59
@zsilbi zsilbi changed the base branch from v2 to main September 5, 2024 11:59
@zsilbi zsilbi closed this Sep 5, 2024
@zsilbi zsilbi deleted the fix-cloudflare-module-types branch September 5, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant