Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: create a GetTheme hook that returns useTheme() as Theme with all our overrides and keep the consumer files DRY #100

Open
noahehall opened this issue Dec 2, 2022 · 0 comments
Open

ui: create a GetTheme hook that returns useTheme() as Theme with all our overrides and keep the consumer files DRY #100

noahehall opened this issue Dec 2, 2022 · 0 comments

Comments

@noahehall
Copy link
Contributor

noahehall commented Dec 2, 2022 •
edited
Loading

  • currently you have too pull in useTheme and themetype from 2 different packages and its annoying
  • much simpler solution
  • worked in the bff, use on the UI

A

  • pretty sure this whole thing can be resolved by figuring out the module agumentation issue
@noahehall noahehall added this to nirvai Dec 2, 2022
@noahehall noahehall converted this from a draft issue Dec 2, 2022
@noahehall noahehall changed the title create a GetTheme hook that returns useTheme() as Theme with out our overrides and keep the consumer files DRY create a GetTheme hook that returns useTheme() as Theme with all our overrides and keep the consumer files DRY Dec 4, 2022
@noahehall noahehall moved this from FAST lane to THE PITS in nirvai Dec 31, 2022
@noahehall noahehall moved this from THE PITS to FAST lane in nirvai Dec 31, 2022
@noahehall noahehall changed the title create a GetTheme hook that returns useTheme() as Theme with all our overrides and keep the consumer files DRY ui: create a GetTheme hook that returns useTheme() as Theme with all our overrides and keep the consumer files DRY Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
nirvai
Status: FAST lane
Milestone
No milestone
Development

No branches or pull requests
1 participant
@noahehall