MNT: Deprecate nibabel.pydicom_compat #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ZviBaratz @moloney Any chance you could have a very quick look? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1280 +/- ##
==========================================
+ Coverage 91.46% 92.24% +0.77%
==========================================
Files 99 99
Lines 12460 12462 +2
Branches 2460 2561 +101
==========================================
+ Hits 11397 11496 +99
+ Misses 725 643 -82
+ Partials 338 323 -15 ☔ View full report in Codecov by Sentry. |
effigies
force-pushed
the
mnt/deprecate-pydicom_compat
branch
from
0067ab0 to
c367345
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added for the <1.0 to 1.0 transition. We no longer use it internally, and it's out-of-date with more recent deprecations in pydicom 2 that cause test failures in pydicom 3.0.0.dev0.
This PR switches the deprecated
read_filetodcmreadand deprecates our own compatibility shim. I suspect nobody is using it, so we'll give one release cycle and remove it in 7.0 (roughly 1yr).