Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: do not refer to the optional data packages #1275

Merged
merged 2 commits into from
Dec 3, 2023

Conversation

DimitriPapadopoulos
Copy link
Contributor

The rationale is that script doc/source/devel/register_me.py is a Python 2 script that is not compatible with Python 3. Looks like the whole machinery has not been used for ages.

Fixes #1274.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b7ac62) 92.24% compared to head (7155e77) 92.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1275   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files          99       99           
  Lines       12452    12452           
  Branches     2560     2560           
=======================================
  Hits        11486    11486           
  Misses        643      643           
  Partials      323      323           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies mentioned this pull request Dec 3, 2023
15 tasks
@effigies
Copy link
Member

effigies commented Dec 3, 2023

@DimitriPapadopoulos Can you remove data_pkg_discuss and data_pkg_uses as well?

The rationale is that script `doc/source/devel/register_me.py`
is a Python 2 script that is not compatible with Python 3.
Looks like the whole machinery has not been used for ages.
@DimitriPapadopoulos
Copy link
Contributor Author

Removed file data_pkg_uses.rst and any reference to data_pkg_discuss and data_pkg_uses.

@effigies
Copy link
Member

effigies commented Dec 3, 2023

Beautiful: image

@effigies effigies merged commit 41e6dad into nipy:master Dec 3, 2023
52 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the data_pkg_design branch December 3, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

file constructor in doc/source/devel/register_me.py
3 participants