Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version to header comment. #462

Open
jenstroeger opened this issue Nov 29, 2022 · 3 comments
Open

Add version to header comment. #462

jenstroeger opened this issue Nov 29, 2022 · 3 comments

Comments

@jenstroeger
Copy link

It would be useful if the generated header comment would contain the version of the plugin, e.g.

"""
@generated by mypy-protobuf 3.3.0/libprotoc 3.19.5.  Do not edit manually!
isort:skip_file
"""
@nipunn1313
Copy link
Owner

Sounds like a great idea!

@jenstroeger
Copy link
Author

Thanks @nipunn1313! I’ve not looked through the code yet but do you prefer a PR contribution or is that a change you’ll make yourself?

@nipunn1313
Copy link
Owner

I would take a contribution!

Otherwise, I'd probably get around to it around christmastime. I like the idea as you've spec'd it.

The repo has tests (./run_tests.sh) with some existing generated files (eg https://github.com/nipunn1313/mypy-protobuf/blob/main/test/generated/testproto/test3_pb2.pyi) - so should be doable to update and review.

Change would likely go somewhere here https://github.com/nipunn1313/mypy-protobuf/blob/main/mypy_protobuf/main.py#L36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants