Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin to Buf Registry #356

Open
MHDante opened this issue Mar 14, 2022 · 2 comments
Open

Add plugin to Buf Registry #356

MHDante opened this issue Mar 14, 2022 · 2 comments

Comments

@MHDante
Copy link
Contributor

MHDante commented Mar 14, 2022

Hi! Recently, Buf (org dealing with standardizing protobuf practices) has created a facility for compiling proto files without requiring installation of the individual plugins: https://buf.build/blog/remote-plugin-execution

Adding mypy-protobuf to the repo would allow using it without requiring installation.

In fact, a couple of people have already created the Dockerfile here:
https://github.com/jeffsawatzky/mypy-protobuf-bufbuild
https://github.com/adriansahlman/mypy-protobuf-bufbuild
They have also published a BSR repo under their name.

That said, it would be best if the BSR repository was kept up to date as part of the CI of this repo.
If possible, would you be ok with creating a BSR repo with the nipunn1313 username?
The instructions to do so are here: https://docs.buf.build/bsr/remote-generation/plugin-example

If not, no worries, since the other's solutions will suffice for now.

@nipunn1313
Copy link
Owner

I'm not sufficiently familiar with the buf ecosystem to feel comfortable maintaining this.

However, I'd be happy to include links to other solutions in the README (PRs welcome)

If there's someone else willing to take up the initial work and the maintenance here, I'd also accept PRs that add such dockerfiles along with appropriate CI (potentially a new github action) to make sure it's up to date.

@mfridman
Copy link

mfridman commented Apr 4, 2023

Hey there, this PR can likely be closed. In bufbuild/plugins#470 we added these two plugins to our automated pipeline, which means they get built, tested and deployed with other plugins to https://buf.build/plugins

These plugins were highly requested, awesome job 🎉

https://buf.build/community/nipunn1313-mypy
https://buf.build/community/nipunn1313-mypy-grpc

There's some documentation on how to use Remote Plugins on the docs site.

For @nipunn1313, there is nothing more you need to do. If you continue to publish valid semver versions then plugins will be automatically picked up and pushed to the BSR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants