Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Center phase maps around central mode, avoiding FoV-related outliers #89

Merged
merged 4 commits into from
Feb 14, 2020

Conversation

effigies
Copy link
Member

First pass at #83 (comment).

Will update to follow #83 (comment), shortly.

cc @oesteban @ins0mniac2 @dorianps

@pep8speaks
Copy link

pep8speaks commented Feb 14, 2020

Hello @effigies, Thank you for updating!

Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, pip install flake8 and then run flake8 sdcflows.

Comment last updated at 2020-02-14 21:06:21 UTC

@effigies effigies changed the base branch from master to maint/1.0.x February 14, 2020 19:07
@effigies effigies force-pushed the fix/double_mode_partial_fix branch from 2c3e3a3 to 88dd7ad Compare February 14, 2020 19:07
@effigies effigies changed the title FIX: Center phase maps around second mode when first is minimum FIX: Center phase maps around central mode, avoiding FoV-related outliers Feb 14, 2020
Copy link
Contributor

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems much more robust

@effigies effigies force-pushed the fix/double_mode_partial_fix branch from 5472fcb to f4a2966 Compare February 14, 2020 21:06
@effigies
Copy link
Member Author

Accidentally merged the CI fixes into master instead of maint/1.0.x, so now they're in here, too.

@effigies effigies merged commit be1b766 into nipreps:maint/1.0.x Feb 14, 2020
@effigies effigies deleted the fix/double_mode_partial_fix branch February 14, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants