Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Half stars #18

Open
asaf opened this issue Jan 4, 2016 · 8 comments
Open

Half stars #18

asaf opened this issue Jan 4, 2016 · 8 comments
Assignees
Labels
Milestone

Comments

@asaf
Copy link

asaf commented Jan 4, 2016

Hey,

Why half stars are not supported any longer?

Thanks.

@ninjasort
Copy link
Owner

I was initially trying to port the CSS-based clipping to SVG, but saw that React didn't support the mask attribute so pulled out the half stars. I can try to put it back in with another clipPath approach and see how that goes. Otherwise, we'll need to wait until react supports the mask attribute. I'll try to get to this in v1.5

@asaf
Copy link
Author

asaf commented Jan 4, 2016

Crap :)

this is one of the nicest features of this component,

Thanks for answering!

@ninjasort
Copy link
Owner

It will be back soon enough. Sorry for the inconvenience.

@ninjasort ninjasort added this to the v1.5.x milestone Jan 6, 2016
@ninjasort ninjasort self-assigned this Jan 6, 2016
@asaf
Copy link
Author

asaf commented Jan 15, 2016

Any ETA for this one?

@asaf
Copy link
Author

asaf commented Jan 25, 2016

Possible solution: http://codepen.io/mrk1989/pen/mLeHJ

@ninjasort
Copy link
Owner

Yeah, looks good. I'll try to work this in, thanks.

@pkhand0
Copy link

pkhand0 commented May 4, 2017

Still it is not supporting decimal rating..

@ninjasort
Copy link
Owner

Hey, sorry about that. I've been super busy. I'll be refactoring a lot of this module when I get some time coming up. Hang tight!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants