Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a fix to music restarting when the song ends. #132

Merged
merged 1 commit into from
Jan 2, 2021
Merged

Added a fix to music restarting when the song ends. #132

merged 1 commit into from
Jan 2, 2021

Conversation

Injourn
Copy link
Contributor

@Injourn Injourn commented Dec 30, 2020

Fixed a bug that would cause the song to repeat after it ended during the transition. Honestly I can't explain this very well so hopefully this video does a better job.

Note: this bug would sometimes not occur if the game was paused at some point.

2020-12-29.23-31-23_Trim.mp4

@ninjamuffin99 ninjamuffin99 merged commit a787138 into FunkinCrew:master Jan 2, 2021
@ninjamuffin99
Copy link
Member

nice! thanks!

@sqirradotdev
Copy link
Contributor

sqirradotdev commented Jan 4, 2021

Very cool, by the way it also happened to the vocals, this PR only fixes the instrumental part of the song. You might wanna make another PR to fix the vocals.

kudorado pushed a commit to kudorado/Funkin that referenced this pull request Jul 18, 2021
Added a fix to music restarting when the song ends.
kudorado pushed a commit to kudorado/Funkin that referenced this pull request Jul 18, 2021
Friday Night Funkin' EYY's, but GF cheers too
ninjamuffin99 added a commit that referenced this pull request Mar 9, 2023
Added a fix to music restarting when the song ends.
@EliteMasterEric EliteMasterEric added this to the Legacy milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants