From 35b02218c0e63b0300082b6ea4368a66541ddbc5 Mon Sep 17 00:00:00 2001 From: Daniel Date: Mon, 28 Oct 2024 18:02:36 +0900 Subject: [PATCH] Workflows: re-export grayscale icons to make guidelines_enforcer's icon check happy The glyph build task seems to be working perfectly fine with icons of bit depth lower than 8bpp, but the guidelines_enforcer enforces 8bpp. Note that the final app binary size is unaffected by this change, as the glyph build task reduces the bit per pixel again. --- Makefile | 11 ++++++++++- glyphs/app_nimiq_64px.gif | Bin 727 -> 727 bytes icons/app_nimiq_32px.gif | Bin 223 -> 987 bytes icons/app_nimiq_40px.gif | Bin 241 -> 1007 bytes 4 files changed, 10 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 11c1490..ed80699 100755 --- a/Makefile +++ b/Makefile @@ -67,7 +67,16 @@ DISABLE_STANDARD_APP_FILES = 1 # control, also Colors > Dither might be used. # - Set the Layer > Layer Boundary Size to the intended size of the final image, centering the content. Then Image > Fit # Canvas to Layers. -# - Export the image as gif, which should be saved with the desired bits per pixel, if following these steps. +# - Save the icon as xcf with the indexed color map which can be used for future changes to the image. +# - For binary black/white icons: export the icon with indexed color mode as gif, which will save as 1bit-per-pixel. +# For grayscale icons: The guidelines_enforcer.yml workflow expects grayscale images to have 8bit-per-pixel depth +# (even though the glyph build task seems to be compatible with lower bit-per-pixel), therefore change the Image > +# Mode to Grayscale and then export as gif. Do not overwrite the xcf file, to keep it in indexed mode. +# For some reason, for glyphs/app_nimiq_64px.gif, but not for the other icons, this made the glyph build task complain +# that the image is not indexed. So not quite sure yet, what the proper procedure would be here. Also tried, re-export +# of app_nimiq_64px.gif via https://www.photopea.com/, which exports with a color map with 256 entries, excess entries +# simply being filled up as black, but that still had 4bpp depth the enforcer complained about. Switching to Grayscale +# and then back to an indexed palette with 32 colors seems to have done the trick. ICON_NANOS = icons/app_nimiq_16px.gif ICON_NANOX = icons/app_nimiq_14px.gif ICON_NANOSP = icons/app_nimiq_14px.gif diff --git a/glyphs/app_nimiq_64px.gif b/glyphs/app_nimiq_64px.gif index f112ee399e195fbfa62d2dce9575d80646cb41b4..23add52010ff0613a9e5cc55024ced7ed1cd2bd2 100644 GIT binary patch delta 655 zcmV;A0&xA;1=j_CM@dFFH(@{kKmg+q0QdLzA0HntFE0-d4@XBw00012S6AQP-|z45 zx3{;KmzRf!htJQ?r>Cc9XJ>bJcPsz^002M$KmY&){t(DXtGzhu&Ab0#D2`-lo@lDB z=b;!xEYE}>+jw0Y%fVI&n2<&++G5AVPjY}2XGdLbD)s$;7KGuGM(q+FKgQEb7U0Y^ zfpX>8M#<7R&VW!gjB+{J%6_RxbmS6lNtdYe+)37Tt#vh%^kZS z2#Gt0{@El>9GR+uf`{*RiTszbqDzY~Cs{b)5hX~KBQuU9rw#y?W!U1OYe})_%cDk< z4v# zck}ASOR*<_MO&i|S+z@1Y+=4fxp6G0_8eHldm~E@P!b4G!Hx+_j$CvjM+1E@Ki*s5 zZt2se^os98;ipOgKLdOE-eIH-)_z|F2OV@u`@Jat~b7!;Eb z0v0Mn1GK$L;bbH|M3wZtj+Iw#G*2iCGsH!n_<*8wg*WQ2x5*UyO50g*=7Fb~c z(0y={f>W*M;D!S#WT0f^ysBo-Jzhaez=^KOP9>0tS=50vS(gCGY?M delta 655 zcmV;A0&xA;1=j_CM@dFFH(@{kKmg+p000005fKq0A|f+0Geks0RaI4HW@dMHcZi6H znVFfYs;axYyUfhY-QC^p?(YBp|11Ci002M$KmY&){_x33tGzhu&Ab0#D2`-lo@lDB zXOk2}EYHLs+jw0UNW)eOn2<&++G5AWPtt%DXGdLbD)s$;5QO2AM(q*~KgQEb9^lNi zfpTToM#<7RuHaB9jB+{J%g=v0|kbMX(V~vrQepVz0T!oke z0(_xnqo8I7i6UY|aG$Pb3?mK(hL@$GxTd+gHX{qHdWWC9!~=jJ4vfN)#m&0UnjMSE zQhT6_RxbmR}lNtdYe-sd)Tt#vh%^kZS z2#Gt0{@El>9GR*@f`{*RiTszbqDzY~Cs}CV5hX~KBQuU9r|tokW!U1OYe})_%cDk< z29QaC)<-`=`yrjGv?w_O7GT&6iqITUsxAY7HCn*JG=f~|`5VhNDboqw96{A3wW`># zck}ASOR?vJMO&i|S+z@1Y+=4fxp6G0_8eHldm~F0P!b4G!Hx+_j$Cvj#{zvYKi&)A zZt2se^os98;ipMgKLdOE-eKzZ@bbH|M0eJoZ+Iw#G*2iCGsH!n_<*8wg*WQ2x5*UyO2a`|&7FZzw z(0y={f>W*M;D!S#W`YA<0f^ysBo-(@hafC)--RPSNaB1Y2tu8OD`wbYd#kC?T6)z5 p_#*(dv9Vx&EdDs$4-J5);)pE<0AmRz=^KOP7r0tJ)40vW#4CmjF) diff --git a/icons/app_nimiq_32px.gif b/icons/app_nimiq_32px.gif index d306483f32c6da7cc0aa70caeb85f8ce8fcccafe..5e9d3639816126a7894bcb6163f22314e5c64cde 100644 GIT binary patch literal 987 zcmV<110?)MNk%v~VITk?0OtSz000010RaL60s{jB1Ox;H1qB8M1_uWR2nYxX2?+`c z3JVJh3=9kn4Gj(s4i66x5D*X%5fKs+5)%^>6ciK{6%`g178e&67#J8C85tTH8XFrM z92^`S9UUGX9v>ecARr(iAt53nA|oRsBqSsyB_$>%CMPE+C@3f?DJd!{Dl021EG#T7 zEiEoCE-x=HFfcGNF)=bSGBYzXG&D3dH8nOiHa9mnI5;>tIXOByIy*Z%JUl!-Jv}}? zK0iM{KtMo2K|w-7LPJACL_|bIMMXwNMn^|SNJvOYNl8jdN=r*iOiWBoO-)WtPESuy zP*6}&QBhJ-Qd3h?R8&+|RaI72R##V7SXfwDSy@_IT3cINTwGjTU0q&YUSD5dU|?Wj zVPRroVq;@tWMpJzWo2e&W@l$-XlQ6@X=!R|YHMq2Y;0_8ZEbFDZf|dIaBy&OadC2T za&vQYbaZreb#-=jc6WDoczAeud3kzzdV70&e0+R;eSLm@et&;|fPjF3fq{a8f`fyD zgoK2Jg@uNOhKGlTh=_=ZiHVAeii?YjjEszpjg5|uj*pLzkdTm(k&%*;l9Q8@l$4Z} zm6ev3mY0{8n3$NEnVFiJnwy)OoSdAUot>VZo}ZteprD|kp`oIpqNAguq@<*!rKP5( zrl+T;sHmu^si~@}s;jH3tgNi9t*x%EuCK4Ju&}VPv9YqUva_?Zw6wIfwY9dkwzs#p zxVX5vxw*Q!y1To(yu7@dCU$jHda z$;ryf%FD~k%*@Qq&CSlv&d<-!(9qD)(b3Y<($mw^)YR0~)z#M4*4Nk9*x1lt)=I7_<=;-L_>FMg~>g((4 z?Ck9A?d|UF?(gsK@bK{Q@$vHV^7Hfa^z`)g_4W4l_V@Sq`1ttw`T6?#`uqF){QUg= z{r&#_{{R2~EC2ui03ZM$000QU0RIUbNU)&6g9sBUTxihUE+P;kN`$z}9m9d$L;%>x zv17*>-7fySgdhpouW!EV8ue J(*^?q06W)H+W`Oo literal 223 zcmV<503iQINk%v~VITk?0OJn;0000H5fLIHA~Q2HL_|bYRaItYW_NdYh=_=pnVG7p zs=K?p%*@Q)-QDi)?*IS)EC2ui03ZM$000D(@X1N5y*TS_-6CKpf{VjVjR34{+YZh7 z9B%C%Cu8p{!xcOp!IV)1gNlq}aO4SymP9j{xHP86ScQh=;V8Op&^G~!d4>%MC7fRN3n_FVev(gh`ek)`XTz+2^4FQ8%6;gRs7fW?d8F*}a8GT)V8iHMg8i!Mf Z8x2fT15g|e3?r}v46HJ>wzn1$06X=iS&IMw diff --git a/icons/app_nimiq_40px.gif b/icons/app_nimiq_40px.gif index 0a23d700eb141b2ac9d045be6c12c2c78095c4f7..bb84c0425cab4f6b30d5ab3ceb21fdc167154277 100644 GIT binary patch literal 1007 zcmV6ciK{6%`g178e&67#J8C85tTH8XFrM z92^`S9UUGX9v>ecARr(iAt53nA|oRsBqSsyB_$>%CMPE+C@3f?DJd!{Dl021EG#T7 zEiEoCE-x=HFfcGNF)=bSGBYzXG&D3dH8nOiHa9mnI5;>tIXOByIy*Z%JUl!-Jv}}? zK0iM{KtMo2K|w-7LPJACL_|bIMMXwNMn^|SNJvOYNl8jdN=r*iOiWBoO-)WtPESuy zP*6}&QBhJ-Qd3h?R8&+|RaI72R##V7SXfwDSy@_IT3cINTwGjTU0q&YUSD5dU|?Wj zVPRroVq;@tWMpJzWo2e&W@l$-XlQ6@X=!R|YHMq2Y;0_8ZEbFDZf|dIaBy&OadC2T za&vQYbaZreb#-=jc6WDoczAeud3kzzdV70&e0+R;eSLm@et&;|fPjF3fq{a8f`fyD zgoK2Jg@uNOhKGlTh=_=ZiHVAeii?YjjEszpjg5|uj*pLzkdTm(k&%*;l9Q8@l$4Z} zm6ev3mY0{8n3$NEnVFiJnwy)OoSdAUot>VZo}ZteprD|kp`oIpqNAguq@<*!rKP5( zrl+T;sHmu^si~@}s;jH3tgNi9t*x%EuCK4Ju&}VPv9YqUva_?Zw6wIfwY9dkwzs#p zxVX5vxw*Q!y1To(yu7@dCU$jHda z$;ryf%FD~k%*@Qq&CSlv&d<-!(9qD)(b3Y<($mw^)YR0~)z#M4*4Nk9*x1lt)=I7_<=;-L_>FMg~>g((4 z?Ck9A?d|UF?(gsK@bK{Q@$vHV^7Hfa^z`)g_4W4l_V@Sq`1ttw`T6?#`uqF){QUg= z{r&#_{{R2~EC2ui04M+`000Qo0RIUbNU)&6g9sBUT*$DY!-o(fM(lP+1b~YeGiDTV zr<=ro?ucj{Ns@>=iJ3^M)R<}F%9j{DKD+}H=ADPkYSv`tu!>HYCK;;wSyRY_ zN0uGvHE%|qSp8z;dXTDM09Oq@&D$~|(!5L;&Skr+p-;AM8}=OwxFOB4Hy;}Qnz-R& dsEr}wRk{}<#iTVkmi|b)w(Z-vb1w`C06V?4<_!P< literal 241 zcmVMqHirP5XqpN~BR&qH z&NShO39YNixc?~E=KusAK8#|K;VCGAHjd(1RBRk3>Q8XXdFX8xa6ImYHJ8