Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove caching gems and installing Bundle steps on the review_pull_request workflows #397

Open
chornerman opened this issue Feb 3, 2023 · 0 comments

Comments

@chornerman
Copy link
Member

chornerman commented Feb 3, 2023

Why

Since we migrated to use the ruby/setup-ruby action for setting up Ruby on the review_pull_request workflows, we can set bundler-cache: true instead of manually caching gems and installing Bundle on different steps. Please check out more detail on the documentation.

Screenshot 2566-02-03 at 10 50 05

For the POC, please check out this PR

Who Benefits?

Everyone

Acceptance Criteria

On review_pull_request workflows (both inside .cicdtemplate and .template)

  • Remove Cache gems and Install Bundle and check environment versions steps
  • Add bundler-cache: true to Set up Ruby step
@ryan-conway ryan-conway added this to the 3.18.0 milestone Feb 23, 2023
@ryan-conway ryan-conway modified the milestones: 3.18.0, 3.19.0 Mar 29, 2023
@ryan-conway ryan-conway modified the milestones: 3.19.0, 3.20.0 May 2, 2023
@ryan-conway ryan-conway modified the milestones: 3.20.0, 3.21.0 Jun 1, 2023
@ryan-conway ryan-conway modified the milestones: 3.21.0, 3.22.0 Jun 30, 2023
@ryan-conway ryan-conway modified the milestones: 3.22.0, 3.23.0 Jul 19, 2023
@ryan-conway ryan-conway modified the milestones: 3.23.0, 3.24.0, 3.25.0 Aug 30, 2023
@ryan-conway ryan-conway removed this from the 3.25.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants