From 244ee1ff5ee1390602b6b5f7437e112a1d1eb1a8 Mon Sep 17 00:00:00 2001 From: Christopher Paciorek Date: Fri, 22 Dec 2023 16:10:10 -0800 Subject: [PATCH] add name mangling of . to nf names (#1383) --- packages/nimble/R/all_utils.R | 1 + packages/nimble/inst/NEWS.md | 3 +++ 2 files changed, 4 insertions(+) diff --git a/packages/nimble/R/all_utils.R b/packages/nimble/R/all_utils.R index 057b1a01d..5c1fa8506 100644 --- a/packages/nimble/R/all_utils.R +++ b/packages/nimble/R/all_utils.R @@ -24,6 +24,7 @@ labelFunctionMetaCreator <- function() { nextIndex <<- 1 return(invisible(NULL)) } + envName <- gsub("\\.", "_dot_", envName) lead <- paste(lead, envName , sep = '_') ans <- paste0(lead, nextIndex - 1 + (1:count)) nextIndex <<- nextIndex + count diff --git a/packages/nimble/inst/NEWS.md b/packages/nimble/inst/NEWS.md index 3861cc867..05e09035a 100644 --- a/packages/nimble/inst/NEWS.md +++ b/packages/nimble/inst/NEWS.md @@ -12,6 +12,9 @@ ## DEVELOPER LEVEL CHANGES +- Fix error with name mangling affecting packages that use nimble + and have dot(s) in the package name (issue #1332) + - Make change to `nimble-package` documentation to use `"_PACKAGE"` instead of `@docType` per CRAN request (issue #1359).