Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atlas "develop", add local paths to nim.cfg #60

Open
enthus1ast opened this issue Aug 4, 2023 · 5 comments
Open

Atlas "develop", add local paths to nim.cfg #60

enthus1ast opened this issue Aug 4, 2023 · 5 comments

Comments

@enthus1ast
Copy link

Atlas should have another option,
to just put local paths in the nim.cfg.

This way we could developing a module and use it directly in the consuming application.

For example it could be:

atlas develop /path/to/module 

This would then add the path to the module to the nim.cfg.
It could also add this to the nimble file?

@Araq
Copy link
Member

Araq commented Aug 4, 2023

What's the benefit over just adding the path yourself to nim.cfg?

@enthus1ast
Copy link
Author

It could maybe also install dependencies, and also maybe add the module to the nimble file.
Then later when the module is done everything is ready to be released.

But yes, one can just add the path by hand, but for what we need tooling in general then.

@Araq
Copy link
Member

Araq commented Aug 4, 2023

/path/to/module might not have a corresponding URL yet so maybe it cannot be added to the Nimble file. I don't see why it would be useful. There is already atlas use dependency which serves a more useful use case.

@elcritch
Copy link
Contributor

elcritch commented Aug 4, 2023

There is already atlas use dependency which serves a more useful use case.

More specifically if you pass a path to atlas use file://../dependency it'll use that path and try and find it's Nimble file. It should add it to nim.cfg.

Also you can setup a url.rules file that transforms the name to some path like is done in the integration tests.

Overall I also think atlas develop goes against Atlas's style of providing workspaces. For example, setup the Atlas workspace to be in a parent folder of both projects.

@elcritch
Copy link
Contributor

elcritch commented Aug 4, 2023

😆 Though looks it adds requires "file://../mydep" to the local Nimble file. The nim.cfg works. I'll get a fix for the requires up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants