Re-add namespace support #117
Comments
elcritch
added a commit
to elcritch/atlas
that referenced
this issue
Mar 30, 2024
This PR started to work on nim-lang#117 but uncovered a few other items which needed cleaned up or fixed. Changes: Combine multiple ways to search for Nimble files into one place fixes some edge cases in handling finding Nimble files fixes issue with writing default config file and handling the deps cli option osutils.nim provides shims for unit testing proc's using a subset of file operations unit tests for various nimble file states unit tests for parsing PkgUrl's fixes some adhoc git execs to use the gitops module, restoring logging etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Notes for re-adding support for namespaces.
It seems the proc's
pkgUrlToDirnameandextractProjectNameboth need updating and maybe refactoring. Also, the GitHub search will need re-adding if it's not present. It would be good to review the package resolution in version 0.6.3 to ensure all the edge cases are handled.Also, it'll likely be a good time to fix up the on disk directory paths to support relative paths from the workspace.
It'd be ideal to write unit tests for this before setting up integration tests.
The text was updated successfully, but these errors were encountered: