fix CI tests/errmsgs/tgcsafety.nim #17721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Araq I'm merging this to unbreak nim CI; see explanation for post-mortem |
timotheecour
added a commit
to timotheecour/Nim
that referenced
this pull request
Apr 16, 2021
timotheecour
added a commit
that referenced
this pull request
Apr 16, 2021
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes nim broken CI.
postmortem:
nimouttoo lax #16698 got merged and CI for simplify asyncfutures, asyncmacro #17633 was not re-run after fix #16693: testament specnimouttoo lax #16698 was mergednimouttoo lax #16698this fixes nim CI.
one way to avoid such problems in the future would be to re-run CI for each PR before merging if some PR was merged before the CI for that PR was last run; this could be automated. But that could be costly. Another way would be to manually do this for very old PR's that have been green for a long time and for which many PR's were merged in the meantime.