Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove package level FractionDigits #26

Closed
nikolaydubina opened this issue Nov 29, 2024 · 0 comments · Fixed by #27
Closed

remove package level FractionDigits #26

nikolaydubina opened this issue Nov 29, 2024 · 0 comments · Fixed by #27
Assignees
Labels
bug Something isn't working

Comments

@nikolaydubina
Copy link
Owner

nikolaydubina commented Nov 29, 2024

this breaks package level variables and very bug prone. make it private.

copy dir into multiple static common versions.

to reproduce:

  1. package A. init map with .FromInt
  2. package B imports A and sets in init() num fraction digits
  3. package B sees values in package A initialized with different fraction digits
  4. 💥
@nikolaydubina nikolaydubina added the bug Something isn't working label Nov 29, 2024
@nikolaydubina nikolaydubina self-assigned this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant