-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preprocess hooks.json #117
Comments
@aarohmankad thanks for investigating! How do these two points help with issue #9 ? |
Oh these are just something I noticed while looking at #9, they're not dependencies. |
@aarohmankad sorry, I was bit in a hurry last time. I totally agree on we shouldn't use indices as keys. Rather it would be better to use the repo url + hook name as this should be unique. I'm opposed to sorting hooks.json since this probably would make it either harder to merge or contribute due merge conflicts. |
Why don't use hook.name as key cause there are no dups? |
@dmitryrn there are plenty of duplicates e.g. |
I was taking a look at the repo to see if I could add #9 (show preview of hook), and I noticed some aspects of processing the hooks could be improved. This issue can serve as an umbrella issue for the following improvements:
The text was updated successfully, but these errors were encountered: