Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocess hooks.json #117

Open
2 tasks
aarohmankad opened this issue Jun 13, 2019 · 5 comments
Open
2 tasks

Preprocess hooks.json #117

aarohmankad opened this issue Jun 13, 2019 · 5 comments

Comments

@aarohmankad
Copy link

I was taking a look at the repo to see if I could add #9 (show preview of hook), and I noticed some aspects of processing the hooks could be improved. This issue can serve as an umbrella issue for the following improvements:

  • Sort hooks.json on every pull request (using TravisCI?)
  • Add unique keys to each hook on every pull request. We probably shouldn't use indices as a key.
@nikgraf
Copy link
Owner

nikgraf commented Jun 14, 2019

@aarohmankad thanks for investigating! How do these two points help with issue #9 ?

@aarohmankad
Copy link
Author

Oh these are just something I noticed while looking at #9, they're not dependencies.

@nikgraf
Copy link
Owner

nikgraf commented Jun 24, 2019

@aarohmankad sorry, I was bit in a hurry last time. I totally agree on we shouldn't use indices as keys. Rather it would be better to use the repo url + hook name as this should be unique.

I'm opposed to sorting hooks.json since this probably would make it either harder to merge or contribute due merge conflicts.

@dmitryrn
Copy link

dmitryrn commented Oct 3, 2019

Why don't use hook.name as key cause there are no dups?

@nikgraf
Copy link
Owner

nikgraf commented Oct 14, 2019

@dmitryrn there are plenty of duplicates e.g. useFetch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants