Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMCONNECT (MINIMED CONNECT BRIDGE) #137

Closed
bjornoleh opened this issue Dec 20, 2021 · 11 comments
Closed

MMCONNECT (MINIMED CONNECT BRIDGE) #137

bjornoleh opened this issue Dec 20, 2021 · 11 comments

Comments

@bjornoleh
Copy link
Contributor

@psonnera and @bewest

I just came across this. Is this still accurate after the latest NS release?

http://nightscout.github.io/nightscout/setup_variables/?h=openaps#mmconnect-minimed-connect-bridge

This plugin is NOT functional with Heroku: do not enable it.

https://github.com/nightscout/cgm-remote-monitor/releases/tag/14.2.5

@psonnera
Copy link
Collaborator

@bjornoleh I don't have feedback from beta testers. Do you?

@bjornoleh
Copy link
Contributor Author

No, I have no idea beyond the release notes and the PRs that went into that release. Ben might know more.

@psonnera
Copy link
Collaborator

Tried an European account and got 403. Another US user same.

@bewest
Copy link
Member

bewest commented Dec 26, 2021

Thanks for testing. It appears public hosting platforms like Heroku tend to get blocked. It still appears that doing this from a mobile rig, or a "sidecar" deployment still works, or on private infrastructure still works.

Is there a page/directory to add a permalink for issues like this to add more details?
Thanks for all the testing and contributions.

@bewest
Copy link
Member

bewest commented Sep 3, 2022

Am considering deprecating this plugin without additional contributions. xdripCarelinkFollower does a great job of copying data from Medtronic cloud and copying it to Nightscout. We need additional contributors to ensure the plugin matches the expected behavior and to verify usability within different environments.

There may be additional challenges, such as MFA threatening the technical viability of this plugin. nightscout/minimed-connect-to-nightscout#34

I've heard of some success from people using sidecar modules as well.

@psonnera
Copy link
Collaborator

psonnera commented Sep 6, 2022

@bewest please don't. The plugin might work on home hosted servers. We need to try it on new solutions. We know Heroku and others are blacklisted but maybe some aren't. Also some hosted services might use it. @ktomy ?

@bewest
Copy link
Member

bewest commented Sep 23, 2022

No worries, I'm in no rush to deprecate it and it will issue deprecation warnings when used before it gets removed. My concern is that this isn't actually working for anyone without changes. So it may be time to start issuing warnings if this feature gets turned on.

@psonnera
Copy link
Collaborator

@petervanrijt was that tried on Synology? If the plugin is functional I'd believe a home based IP might not be blocked...
PS: Terry says it doesn't work on Railway...

@bewest
Copy link
Member

bewest commented Sep 24, 2022

I've mentioned before I think it's more than a blocking issue; there may be changes required as well. We need to do a careful audit of xdripcarelinkfollower to make sure we're using the same strategy for authentication. In theory it should work well on synology, good catch @psonnera. If there were no issues with the code I would expect it to work on Railway; since it doesn't it hints something is wrong with the code myself. Additional help and testing details are of course welcome.

@petervanrijt
Copy link
Contributor

We are not using it. But I can provide quickly a test environment for it, if someone has the equipment and time for testing :)

@psonnera
Copy link
Collaborator

The new plugin is under testing (available in dev) and this will be the final solution. mmconnect will be deprecated in the future.
https://github.com/nightscout/nightscout-connect#minimed-carelink

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants