Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary Override fails #7141

Closed
kristianwh opened this issue Oct 25, 2021 · 7 comments
Closed

Temporary Override fails #7141

kristianwh opened this issue Oct 25, 2021 · 7 comments

Comments

@kristianwh
Copy link

kristianwh commented Oct 25, 2021

Describe the bug
Trying to set a temporary override.
This results in an error message in the browser:

To Reproduce
Steps to reproduce the behavior:

  1. Go to Log treatment
  2. Choose Event type "Temporary override"
  3. Choose a "Reason"
  4. Click Submit form
  5. See error

Expected behavior
Expected that the override should be set

Screenshots
image
image

Your setup information

  • What version of Nightscout (e.g. 14.2.3)
  • What type of CGM, and how do you get your data there? (Dexcom G6 and Bridge, but N/A in this case)
  • Is your issue specific to a browser (Firefox/Safari/Chrome?) or a device (Android phone, etc.)? No, fails in all I've tried.

Additional context
Also confirmed by others who upgraded to this version.

@bjornoleh
Copy link
Contributor

@sulkaharo and @bewest , it seems Release 14.2.3 broke remote overrides for iOS Loop.

Let me know if you need more info, I may have some time to test right now.

@sulkaharo
Copy link
Member

@bjornoleh
Copy link
Contributor

bjornoleh commented Oct 25, 2021

@bewest Wonder if it's 14.2.2...14.2.3diff-770ec3cf5b644df350f403859877711e4e19266bc83793911a4150872dba7272L19 removing the extended parsing?

@sulkaharo It wasn´t quite clear to me which diff you were trying to link to above, but I took a chance it might be related to 41fdb8e (respect per route body-parser configuration)

Reverting this one commit did allow me to send remote overrides to iOS Loop, so it seems like this is the culprit.

@sulkaharo
Copy link
Member

#7144 should fix this

@bjornoleh
Copy link
Contributor

#7144 should fix this

Thanks @sulkaharo, I just deployed your add_wares_to_v2 branch, and remote overrides is working for me now.

@bjornoleh
Copy link
Contributor

I just deployed dev, which is also working now that the PR was merged.

@bewest
Copy link
Member

bewest commented Oct 25, 2021

Thanks to your contributions, we've released 14.2.4 https://github.com/nightscout/cgm-remote-monitor/releases/tag/14.2.4. Closing for now.

@bewest bewest closed this as completed Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants