-
Notifications
You must be signed in to change notification settings - Fork 71.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPU load grows in time #6129
Comments
Found a memory leak, fixing. Thank you for the report - the increase on my single instance monitor is so small I didn't notice this... |
Based on monitoring the data loads reported from #6133, looks like this fixes the leak. Can you help validate the fix asap, so I can push this out as a point release? |
Now upgrading all nightscouts, will be report in few hours, |
Awesome, thank you! ❤️ |
Any news yet? Looking at my instance, I don't see the memory use going up anymore. |
What's the memory use before you updated, or is that shown on the graph? |
Small peaks are backup process. Grow of cpu load is from nightscout. |
Right ok, didn't at first notice the creep is that slow. Would it be possible for you to add memory monitoring that tracks the node processes? The CPU use in NS is 100% dependent on the data in the runtime and if CPU is creeping but memory use isn't, that implies the memory use is for the VM instances which allocate more than Node needs and the true Node memory use is not actually tracked. |
Right - given I got a couple confirmations that this seems to at least fix the issue visible in the logs, I merge this to dev and released as 14.0.5, as this should also fix the data backfills. Let's keep this open and please report back here when you have longer term results. |
How does the data look now? Also ping: I released 14.0.6 to fix an issue with batch upload of data from Loop, so you might want to update again. This resolves the outstanding big issues so hopefully there won't be more updates in the next few weeks. |
If you compare that graph to the one on the top where there was clear 10% increase in the average over 24 hours, it looks to me like at least the bad resource leak is gone |
Great! Btw .5 has a small bug that break Device status uploads for Loop users, fixed in .6, so you might want to update once more. Apologies for that. |
NS 14.0.4 , docker hosting for 150 users
after upgrade from 13.0.1 to 14.0.3 than 14.0.4 CPU load grows in time
With 13.0.1 no problem occured.
The text was updated successfully, but these errors were encountered: