Correction Bolus tooltip incorrectly scales BG

[dybs]

Describe the bug
The Correction Bolus tooltip scales a manually-entered BG value by a factor of 18.

To Reproduce
Steps to reproduce the behavior:

1. Set profile units to mg/dl
2. Set client settings Units to mg/dL
3. In Care Portal, create a Correction Bolus treatment and enter a BG value in mg/dL (e.g. 100).
4. Hover the mouse over the treatment in the graph.
5. The tooltip shows the BG value multiplied by 18 (e.g. 1800).
6. NOTE: The Treatement Report shows the entered value, and the treatement dot does appear at the correct position on the graph.

Expected behavior
The treatment tooltip should show the same BG value that was entered.

Screenshots
Profile unit settings - mg/dl:

Client unit settings - mg/dL:

Tooltip:

Treatement report:

Your setup information

• Nightscout 13.0.1
• CGM is Dexcom G5, data uploaded from xDrip+ on Android.
• Have tested on Firefox and Chrome on Windows 10, as well as Firefox on Android.

Additional context
I think the issue is lib/client/renderer.js, appendTreatments.treatmentTooltip() function around line 635 when checking the client units vs the profile units. I thought there might be a case-sensitivity issue (my settings are mg/dL, but the profile showed mg/dl), but doing a lowercase-only comparison did not fix it on my fork.

[jakobsandberg]

This issue was reported back in December (#5384) and a fix was already merged in via #5381. However, that fix has not been released yet (it's currently on the dev branch).

It should go out in the next release.

[dybs]

Ah, thanks, I didn't think to check dev

[pbudzon]

Can confirm this appeared for me today on latest master.