Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COB is always zero when rewinding/scrolling back #5241

Open
naromero77 opened this issue Nov 25, 2019 · 9 comments
Open

COB is always zero when rewinding/scrolling back #5241

naromero77 opened this issue Nov 25, 2019 · 9 comments

Comments

@naromero77
Copy link

Describe the bug
I believe this worked in the recent master but not in dev. The current COB pill displays correct value and updates correctly as time progress. However, if you rewind/scroll back the NS viewer you to a prior time the COB pill always displays zero.

To Reproduce
Set-up is NS dev from a couple of weeks ago. Recent version of Loop dev.

Take NS viewer in a Firefox or another browser and just scroll back: COB is displaying zero, but the current instantaneous COB is correct.

Expected behavior
If you rewind/scroll back the NS viewer, I expect the COB displayed to show the correct value at the prior time.

Screenshots
If applicable, add screenshots to help explain your problem.

Your setup information

  • NS dev
  • G6 Sharebridge
  • FireFox

Additional context
I can add a screenshot, but it would not be interesting. It should always shows "0" in the COB pill when you scroll back. In the present time, COB is displaying correctly.

@woodduckie
Copy link

I've observed this issue after updating to v13. I can't be certain it wasn't there before and I haven't yet had the time to roll back my deployment. To add to the original issue, IOB reflects historical values when scrolling, but COB just shows 0. FWIW, I'm using loop, Firefox /Safari, G6 via bridge.

@Sophieinthecloud
Copy link

Sophieinthecloud commented Jul 29, 2020

NS_COB

I'm having this same issue. When scrolling back in time, The COB shows in the Loop pill when I click it but the COB pill shows 0(see screenshot #1).
A new bolus does show the COB (see screenshot #2).

I'm not exactly sure when it started but I first noticed it after I cleaned mLab. Not sure if that is related or a coincidence.
NS_COB2

@bjornoleh
Copy link
Contributor

@sulkaharo I believe this was mentioned in CGM in the cloud quite recently. Not sure why the issue was closed just now, it still could use some attention.

#6916 mentions a possible fix for that particular issue:
COB: buggfix to show history COB when scrolling the timeline backwards

@naromero77
Copy link
Author

It looks like the bug fix should go in the DIY software which is uploading information into NS. Thus the fix would have to go into OpenAPS, AndroidAPS, and Loop.

@sulkaharo
Copy link
Member

@naromero77 Nope, this is a bug in the COB plugin not fetching the COM data from the device statuses when timeline is being scrolled.

@jgefaell
Copy link

This behavior is still present in Nightscout 14.2.6

It would be very appreciated if it could be addressed. Thank you.

@bjornoleh
Copy link
Contributor

The fix mentioned in #6916 still works great

@bjornoleh
Copy link
Contributor

bjornoleh commented Aug 21, 2023

I copied the fix mentioned previously, and created PR #8081. Credits to @klalle / @maja-lofgren

pinging @bewest and @sulkaharo in case this gets lost in the git spam.

@bewest
Copy link
Member

bewest commented Aug 22, 2023

Thanks, @bjornoleh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants